Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update atob api #1450

Merged
merged 2 commits into from
Dec 25, 2022
Merged

feat: update atob api #1450

merged 2 commits into from
Dec 25, 2022

Conversation

ylmin
Copy link
Contributor

@ylmin ylmin commented Dec 24, 2022

What does this PR do?
This function is only provided for compatibility with legacy web platform APIs and should never be used in new code, because they use strings to represent binary data and predate the introduction of typed arrays in JavaScript. For code running using Node.js APIs, converting between base64-encoded strings and binary data should be performed using Buffer.from()

How should this be tested?
Check that the warning is gone in code scanning results

@ylmin ylmin requested a review from bigint as a code owner December 24, 2022 13:20
@vercel
Copy link

vercel bot commented Dec 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
api ✅ Ready (Inspect) Visit Preview Dec 24, 2022 at 6:07PM (UTC)
web ✅ Ready (Inspect) Visit Preview Dec 24, 2022 at 6:07PM (UTC)

@vercel vercel bot temporarily deployed to Preview – api December 24, 2022 13:21 Inactive
@bigint bigint enabled auto-merge (squash) December 25, 2022 14:26
@bigint bigint disabled auto-merge December 25, 2022 14:26
@bigint bigint merged commit 909c12d into heyxyz:main Dec 25, 2022
@gitpoap-bot
Copy link

gitpoap-bot bot commented Dec 25, 2022

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Lenster Contributor:

GitPOAP: 2022 Lenster Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants