Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: profile preview 404 in popover #1523

Merged
merged 7 commits into from
Jan 5, 2023
Merged

fix: profile preview 404 in popover #1523

merged 7 commits into from
Jan 5, 2023

Conversation

sasicodes
Copy link
Contributor

@sasicodes sasicodes commented Jan 4, 2023 •
edited
Loading

What does this PR do?

Fixes #1481

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@height
Copy link

height bot commented Jan 4, 2023 •
edited
Loading

This pull request has been linked to 1 task:

💡Tip: Add "Close T-226" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@vercel
Copy link

vercel bot commented Jan 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
web ✅ Ready (Inspect) Visit Preview Jan 5, 2023 at 5:29AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
api ⬜️ Ignored (Inspect) Jan 5, 2023 at 5:29AM (UTC)

@vercel vercel bot temporarily deployed to Preview – api January 4, 2023 14:57 Inactive
@sasicodes sasicodes marked this pull request as ready for review January 4, 2023 15:22
@sasicodes sasicodes requested a review from bigint as a code owner January 4, 2023 15:22
@bigint
Copy link
Member

bigint commented Jan 4, 2023

@sasicodes still i can see here 0xf8c5-0x4e

image

@sasicodes
Copy link
Contributor Author

0xf8c5-0x4e

Fixed

@bigint bigint merged commit 3282383 into main Jan 5, 2023
@bigint bigint deleted the T-226 branch January 5, 2023 05:26
@gitpoap-bot
Copy link

gitpoap-bot bot commented Jan 5, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Lenster Contributor:

GitPOAP: 2023 Lenster Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@bigint bigint changed the title fix: profile preview 404 fix: profile preview 404 in popover Jan 5, 2023
sasicodes added a commit that referenced this pull request Jan 16, 2023
@sasicodes @bigint
fix: profile preview 404 in popover (#1523)
8c63a15 
Co-authored-by: bigint <69431456+bigint@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigint bigint bigint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't show user preview if it not exists
2 participants
@sasicodes @bigint