Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set chainid to wagmi connectors #1669

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

zannis
Copy link
Contributor

@zannis zannis commented Jan 23, 2023

What does this PR do?

Explicitly adds chainId to wagmi useConnect hook so that chainId is properly populated when instantiating a WalletConnectConnector.

Fixes #1668

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Successfully connected with WalletConnect to Sequence wallet.

@zannis zannis requested a review from bigint as a code owner January 23, 2023 15:14
@height
Copy link

height bot commented Jan 23, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@vercel
Copy link

vercel bot commented Jan 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
api ✅ Ready (Inspect) Visit Preview Jan 23, 2023 at 3:16PM (UTC)
embed ✅ Ready (Inspect) Visit Preview Jan 23, 2023 at 3:16PM (UTC)
web ✅ Ready (Inspect) Visit Preview Jan 23, 2023 at 3:16PM (UTC)

@vercel vercel bot temporarily deployed to Preview – api January 23, 2023 15:15 Inactive
@vercel vercel bot temporarily deployed to Preview – embed January 23, 2023 15:16 Inactive
@bigint
Copy link
Member

bigint commented Jan 23, 2023

LGTM :shipit:

Rad LGTM

@bigint bigint merged commit febc355 into heyxyz:main Jan 23, 2023
@gitpoap-bot
Copy link

gitpoap-bot bot commented Jan 23, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Lenster Contributor:

GitPOAP: 2023 Lenster Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WalletConnectConnector tries to connect to chainId 1
2 participants