Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add conversation caching #1908

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Conversation

rygine
Copy link
Contributor

@rygine rygine commented Mar 6, 2023

What does this PR do?

Add conversation caching for DMs to drastically speed up conversation loading, especially for users with tons of conversations.

Close ENG-186

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

Load your messages page and confirm that loading of conversations is faster.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

@rygine rygine requested a review from bigint as a code owner March 6, 2023 17:26
@height
Copy link

height bot commented Mar 6, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@vercel
Copy link

vercel bot commented Mar 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
prerender ✅ Ready (Inspect) Visit Preview Mar 6, 2023 at 5:50PM (UTC)
web ✅ Ready (Inspect) Visit Preview Mar 6, 2023 at 5:50PM (UTC)

@vercel vercel bot temporarily deployed to Preview – prerender March 6, 2023 17:50 Inactive
@rygine rygine changed the title feat: add message caching feat: add conversation caching Mar 6, 2023
@bigint
Copy link
Member

bigint commented Mar 6, 2023

Screen.Recording.2023-03-06.at.11.52.55.PM.mov

Still too much time?? no?

@rygine
Copy link
Contributor Author

rygine commented Mar 6, 2023

Still too much time?? no?

just to confirm, this video is after the cache is warm?

if so, what's the time difference between the current production build and this cached version?

@bigint
Copy link
Member

bigint commented Mar 6, 2023

@rygine It reduced to half

30s on main branch
15s in this branch

@bigint
Copy link
Member

bigint commented Mar 6, 2023

It's great improvement 👏🏼

But looking forward for improvement to the core APIs 🙇🏼

Gonna merge this now 🚀

Copy link
Member

@bigint bigint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Rad LGTM

@bigint bigint merged commit 0ec8312 into heyxyz:main Mar 6, 2023
@gitpoap-bot
Copy link

gitpoap-bot bot commented Mar 6, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Lenster Contributor:

GitPOAP: 2023 Lenster Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants