Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set limits for content uploads #2374

Merged
merged 30 commits into from
Apr 7, 2023
Merged

fix: set limits for content uploads #2374

merged 30 commits into from
Apr 7, 2023

Conversation

Seroxdesign
Copy link
Contributor

@Seroxdesign Seroxdesign commented Apr 4, 2023 •
edited by ghost
Loading

What does this PR do?

🤖 Generated by Copilot at 47209cf

Refactor file upload logic and UI for Composer component. Enforce file type and number limits, and improve error handling and code clarity.

Related issues

Fixes #2081

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Explanation of the changes

🤖 Generated by Copilot at 47209cf

  • Refactor file upload logic and error message for attachments in Attachment.tsx (link, link, link, link, link, link)
  • Remove redundant disabled props from input elements in Attachment.tsx (link, link, link)
  • Remove empty line of code in Attachment.tsx (link)

Emoji

🎥🎨♻️

@Seroxdesign Seroxdesign requested a review from bigint as a code owner April 4, 2023 12:47
@vercel
Copy link

vercel bot commented Apr 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
prerender ✅ Ready (Inspect) Visit Preview Apr 7, 2023 10:56am
web ✅ Ready (Inspect) Visit Preview Apr 7, 2023 10:56am

@vercel vercel bot temporarily deployed to Preview – prerender April 4, 2023 12:47 Inactive
@vercel vercel bot temporarily deployed to Preview – prerender April 4, 2023 13:10 Inactive
@Seroxdesign
Copy link
Contributor Author

@bigint,

This is ready for review, I can't see why deployments fail. though

@bigint bigint changed the title set limits for content uploads fix: set limits for content uploads Apr 4, 2023
@vercel vercel bot temporarily deployed to Preview – prerender April 4, 2023 13:23 Inactive
bigint
bigint requested changes Apr 4, 2023
View reviewed changes
packages/workers/sts-generator/.dev.vars.example Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
apps/web/src/components/Composer/Actions/Attachment.tsx Outdated Show resolved Hide resolved
apps/web/src/components/Composer/Actions/Attachment.tsx Outdated Show resolved Hide resolved
apps/web/src/components/Composer/Actions/Attachment.tsx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – prerender April 4, 2023 17:31 Inactive
@vercel vercel bot temporarily deployed to Preview – prerender April 4, 2023 18:43 Inactive
@vercel vercel bot temporarily deployed to Preview – prerender April 4, 2023 18:45 Inactive
@vercel vercel bot temporarily deployed to Preview – prerender April 5, 2023 15:07 Inactive
@vercel vercel bot temporarily deployed to Preview – prerender April 5, 2023 15:35 Inactive
@vercel vercel bot temporarily deployed to Preview – prerender April 5, 2023 19:09 Inactive
@vercel vercel bot temporarily deployed to Preview – prerender April 5, 2023 19:13 Inactive
@vercel vercel bot temporarily deployed to Preview – prerender April 6, 2023 15:27 Inactive
@vercel vercel bot temporarily deployed to Preview – prerender April 6, 2023 17:21 Inactive
@vercel vercel bot temporarily deployed to Preview – prerender April 7, 2023 10:29 Inactive
bigint
bigint approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@bigint bigint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Rad LGTM

@bigint bigint enabled auto-merge (squash) April 7, 2023 10:52
@vercel vercel bot temporarily deployed to Preview – prerender April 7, 2023 10:53 Inactive
@bigint bigint merged commit 87feafb into main Apr 7, 2023
@bigint bigint deleted the sero/dework-29/media-post-limit branch April 7, 2023 10:59
@gitpoap-bot
Copy link

gitpoap-bot bot commented Apr 7, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Lenster Contributor:

GitPOAP: 2023 Lenster Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigint bigint bigint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow only 1 audio or 1 video or 4 images
2 participants
@Seroxdesign @bigint