Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: storybook vercel support #2497

Merged
merged 8 commits into from
Apr 11, 2023
Merged

chore: storybook vercel support #2497

merged 8 commits into from
Apr 11, 2023

Conversation

bigint
Copy link
Member

@bigint bigint commented Apr 11, 2023

What does this PR do?

🤖 Generated by Copilot at 933ea79

Improved the storybook configuration and scripts for the apps/storybook package. Removed some unnecessary or problematic options and dependencies, and added a way to run the storybook locally.

Related issues

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Explanation of the changes

🤖 Generated by Copilot at 933ea79

  • Simplify stories glob pattern to only include .stories files (link)
  • Remove enableShortcuts option from storybook config to fix keyboard navigation and accessibility issues (link)
  • Remove html option from storybook preview config to avoid errors with HTML addon (link)
  • Add start script and serve package to package.json to enable running storybook locally (link, link)

Emoji

🔧⌨️🌐

@vercel
Copy link

vercel bot commented Apr 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
prerender ✅ Ready (Inspect) Visit Preview Apr 11, 2023 11:29am
web 🛑 Canceled (Inspect) Apr 11, 2023 11:29am

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
serve@14.2.0 eval +32 vercel-release-bot
framer-motion@10.11.4 environment +1 popmotion

🚮 Removed packages: @playwright/test@1.31.2

@bigint bigint merged commit 0983d9e into main Apr 11, 2023
@bigint bigint deleted the storybook branch April 11, 2023 11:27
@vercel vercel bot temporarily deployed to Preview – prerender April 11, 2023 11:28 Inactive
@vercel vercel bot temporarily deployed to Preview – web April 11, 2023 11:29 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant