Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor collect form and add simple collect #2844

Merged
merged 27 commits into from
May 19, 2023
Merged

Conversation

bigint
Copy link
Member

@bigint bigint commented May 11, 2023

What does this PR do?

🤖 Generated by Copilot at c821cb4

Refactor the collect settings feature to use a single state object and a new prop for managing the collect settings. Move the referral config component to a different parent component. Use the staging API for testing. Update the collect limit, split, and follower only components to use the new state and prop.

Related issues

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Explanation of the changes

🤖 Generated by Copilot at c821cb4

  • Refactor the collect settings logic to use a single collectModule state that stores all the collect settings in a single object, and a setCollectType prop that updates the collect settings based on the user input (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Move the ReferralConfig component from the AmountConfig component to the CollectForm component, where it is conditionally rendered based on the amount value (link, link)
  • Import the DEFAULT_COLLECT_TOKEN and CollectModules constants from the data and lens modules, respectively, to use them in the collect settings components (link, link)
  • Change the schema URL for the codegen config from https://api-mumbai.lens.dev to https://staging-api-social-mumbai.lens.crtlkey.com to use the staging API for testing the collect settings feature (link)
  • Add the setCollectType prop to the CollectLimitConfig, FollowersConfig, ReferralConfig, and SplitConfig components to use the prop to update the collect settings based on the collect limit input, the follower only toggle, the referral fee input, and the split input, respectively (link, link, link, link)

Emoji

🔄🆕🚀

@vercel
Copy link

vercel bot commented May 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
prerender ✅ Ready (Inspect) Visit Preview May 19, 2023 2:22pm
ui ✅ Ready (Inspect) Visit Preview May 19, 2023 2:22pm
web ✅ Ready (Inspect) Visit Preview May 19, 2023 2:22pm

@vercel vercel bot temporarily deployed to Preview – ui May 11, 2023 11:44 Inactive
@bigint bigint changed the title feat: refactor collect form feat: refactor collect form and add simple collect May 11, 2023
@vercel vercel bot temporarily deployed to Preview – prerender May 11, 2023 11:46 Inactive
@vercel vercel bot temporarily deployed to Preview – prerender May 19, 2023 14:20 Inactive
@vercel vercel bot temporarily deployed to Preview – ui May 19, 2023 14:22 Inactive
@bigint bigint merged commit e808fdf into main May 19, 2023
4 checks passed
@bigint bigint deleted the simpleCollectModule branch May 19, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant