Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: constants #2929

Merged
merged 4 commits into from
May 22, 2023
Merged

refactor: constants #2929

merged 4 commits into from
May 22, 2023

Conversation

bigint
Copy link
Member

@bigint bigint commented May 22, 2023

  • chore: remove SIMPLEANALYTICS_API_ENDPOINT constant
  • chore: remove SIMPLEANALYTICS_API constant
  • chore: rename STS_GENERATOR_WORKER_URL constant

What does this PR do?

🤖 Generated by Copilot at a8e95c7

This pull request updates some constants and their usages in the web app, the data package, and the test code to reflect the latest changes in the infrastructure and the domains. It also removes some unused or outdated constants and improves code comments.

Related issues

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Explanation of the changes

🤖 Generated by Copilot at a8e95c7

  • Remove unused constants for SimpleAnalytics API endpoint and preview mode (link, link, link)
  • Rename STS_TOKEN_URL constant to STS_GENERATOR_WORKER_URL to reflect new Cloudflare worker name (link, link, link)
  • Update getS3Client function in apps/web/src/lib/uploadToIPFS.ts to use renamed constant (link)
  • Add comment to mark LENS_RELAYER_URL constant for removal in packages/data/constants.ts (link)
  • Update comments for AVATAR and COVER constants in packages/data/constants.ts to specify ImageKit transforms (link)
  • Update imageProxy test in tests/packages/lib/imageProxy.spec.ts to use renamed constant (link)

Emoji

🔥🚚🧹

@vercel
Copy link

vercel bot commented May 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
prerender ✅ Ready (Inspect) Visit Preview May 22, 2023 4:14am
web ✅ Ready (Inspect) Visit Preview May 22, 2023 4:14am

@vercel vercel bot temporarily deployed to Preview – prerender May 22, 2023 04:10 Inactive
@bigint bigint enabled auto-merge (squash) May 22, 2023 04:12
@vercel vercel bot temporarily deployed to Preview – prerender May 22, 2023 04:14 Inactive
@bigint bigint merged commit af6d53f into main May 22, 2023
8 checks passed
@bigint bigint deleted the clean-constants branch May 22, 2023 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant