Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add coinbase wallet support #3264

Merged
merged 1 commit into from
Jul 18, 2023
Merged

feat: add coinbase wallet support #3264

merged 1 commit into from
Jul 18, 2023

Conversation

bigint
Copy link
Member

@bigint bigint commented Jul 18, 2023

What does this PR do?

🤖 Generated by Copilot at c2f7be3

Added support for Coinbase Wallet as a web3 provider in apps/web and packages/lib. Updated getWalletDetails function and test case to handle Coinbase Wallet.

Related issues

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Explanation of the changes

🤖 Generated by Copilot at c2f7be3

  • Enable Coinbase Wallet connection by importing and using CoinbaseWalletConnector and APP_NAME in Web3ReactProvider (link,link,link)
  • Add Coinbase Wallet case to getWalletDetails function in getWalletDetails.ts to return name and logo (link)
  • Add test case for Coinbase Wallet to getWalletDetails.spec.ts to verify name and logo (link)

Emoji

🧪🌐🆔

@vercel
Copy link

vercel bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
prerender ✅ Ready (Inspect) Visit Preview Jul 18, 2023 5:31pm
web ✅ Ready (Inspect) Visit Preview Jul 18, 2023 5:31pm

@bigint bigint merged commit 8205e51 into main Jul 18, 2023
5 of 8 checks passed
@bigint bigint deleted the add-coinbase-wallet branch July 18, 2023 17:29
@vercel vercel bot temporarily deployed to Preview – prerender July 18, 2023 17:31 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant