Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove old spaces #3379

Merged
merged 2 commits into from
Jul 27, 2023
Merged

chore: remove old spaces #3379

merged 2 commits into from
Jul 27, 2023

Conversation

bigint
Copy link
Member

@bigint bigint commented Jul 27, 2023

What does this PR do?

🤖 Generated by Copilot at 2606156

This pull request removes the Spaces feature from the lenster web app and its dependencies. It deletes unused code, components, translations, and constants related to Spaces. It also updates the port numbers for some workers and the documentation accordingly.

Related issues

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Explanation of the changes

🤖 Generated by Copilot at 2606156

  • Remove the Spaces feature from the web app and the workers
  • Delete the SpaceSettings, Space, SpacePlayer, SpaceUser, and useCreateSpace components and hooks (link, link, link, link, link)
  • Remove the showSpaceEditor variable and logic from the Editor and NewPublication components (link, link, link, link, link, link, link)
  • Remove the createSpace variable and logic from the NewPublication component (link, link, link)
  • Remove the spaceObject and space variables and logic from the PublicationBody component (link, link)
  • Remove the isSpacesEnabled variable and logic from the PublicationBody component (link)
  • Remove the showSpaceEditor and setShowSpaceEditor properties from the PublicationState interface and the usePublicationStore hook (link, link)
  • Remove the useCreateSpace and SpaceSettings imports from the NewPublication component (link, link)
  • Remove the Space and FeatureFlag imports from the PublicationBody component (link)
  • Remove the translations for the word "Space" and the phrases "What do you want to talk about?" and "Start Space" from the locale files (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Remove the Spaces worker from the list of exposed ports in the ports.md file and the list of packages in the README.md file (link, link)
  • Remove the SPACES_WORKER_URL constant from the constants.ts file and update the port numbers for the LEAFWATCH_WORKER_URL, the ACHIEVEMENTS_WORKER_URL, and the INVITE_WORKER_URL constants (link, link)
  • Update the port numbers for the dev scripts in the package.json files for the achievements and invite workers (link, link)
  • Remove the Spaces feature flag from the FeatureFlag enum and the featureFlags array in the feature-flags.ts file (link, link)

Emoji

🗑️🛠️🧹

@vercel
Copy link

vercel bot commented Jul 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
prerender ✅ Ready (Inspect) Visit Preview Jul 27, 2023 8:25am
web ✅ Ready (Inspect) Visit Preview Jul 27, 2023 8:25am

@bigint bigint enabled auto-merge (squash) July 27, 2023 08:22
@vercel vercel bot temporarily deployed to Preview – prerender July 27, 2023 08:23 Inactive
@bigint bigint merged commit 1c20fe7 into main Jul 27, 2023
8 checks passed
@bigint bigint deleted the rm-spaces branch July 27, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant