Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: oembed #3494

Merged
merged 2 commits into from
Aug 10, 2023
Merged

fix: oembed #3494

merged 2 commits into from
Aug 10, 2023

Conversation

bigint
Copy link
Member

@bigint bigint commented Aug 10, 2023

What does this PR do?

πŸ€– Generated by Copilot at c71a1fe

Refactored getMetadata function in oembed worker to use a custom proxy URL generator and type assertions. This enhances the code quality and efficiency.

Related issues

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Explanation of the changes

πŸ€– Generated by Copilot at c71a1fe

  • Replace @cfworker/base64url dependency with custom getProxyUrl function to reduce bundle size and simplify URL encoding and transformation (link)
  • Refactor getMetadata function to use getProxyUrl function and add type assertions for isLarge and image variables to improve type safety and readability (link)
  • Remove unused variables isProduction and workerUrl from getMetadata.ts (link)

Emoji

πŸš€πŸ§ΉπŸ›‘οΈ

@vercel
Copy link

vercel bot commented Aug 10, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
prerender βœ… Ready (Inspect) Visit Preview Aug 10, 2023 9:37am
1 Ignored Deployment
Name Status Preview Updated (UTC)
web ⬜️ Ignored (Inspect) Visit Preview Aug 10, 2023 9:37am

@bigint bigint merged commit 0b9f785 into main Aug 10, 2023
2 of 5 checks passed
@bigint bigint deleted the fix-oembed branch August 10, 2023 09:36
@vercel vercel bot temporarily deployed to Preview – prerender August 10, 2023 09:37 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant