Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: settings icon margin in notification #3604

Merged

Conversation

foolo
Copy link
Contributor

@foolo foolo commented Aug 22, 2023

What does this PR do?

🤖 Generated by Copilot at a25fa3a

Increased button padding in Notification/Settings.tsx component. This is a UI improvement for the web app.

Before:
Screenshot_2023-08-22_17-07-21

After:
Screenshot_2023-08-22_17-31-30

Related issues

Fixes #3583

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Explanation of the changes

🤖 Generated by Copilot at a25fa3a

  • Increased the horizontal padding of the button in Settings.tsx (link) to improve UI consistency

Emoji

🖥️📏🛠️

@foolo foolo requested a review from bigint as a code owner August 22, 2023 15:04
@foolo foolo linked an issue Aug 22, 2023 that may be closed by this pull request
@vercel
Copy link

vercel bot commented Aug 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
prerender ✅ Ready (Inspect) Visit Preview Aug 22, 2023 8:18pm
web ✅ Ready (Inspect) Visit Preview Aug 22, 2023 8:18pm

@bigint
Copy link
Member

bigint commented Aug 22, 2023

@foolo it should be margin 🙇🏼 there is no space RN right to the button 🙇🏼

@foolo
Copy link
Contributor Author

foolo commented Aug 22, 2023

@foolo it should be margin 🙇🏼 there is no space RN right to the button 🙇🏼

@bigint Ahh, okay. I'll fix it.

@foolo
Copy link
Contributor Author

foolo commented Aug 22, 2023

@bigint Done, I updated the "After" picture. Keeping the button itself narrow as before.

@bigint
Copy link
Member

bigint commented Aug 22, 2023

In desk it looks bit odd 🙈

image

@foolo
Copy link
Contributor Author

foolo commented Aug 22, 2023

In desk it looks bit odd 🙈

@bigint Ah, now I think I understand what you mean. On desktop the cogwheel should have no margin. I updated the PR again. Sorry for lots of back and forth for this tiny PR :)

Looks like this now:
Screenshot_2023-08-22_22-11-32

@bigint bigint merged commit 9b13a8a into main Aug 23, 2023
8 checks passed
@bigint bigint deleted the 3583-settings-icon-dont-have-enough-space-aka-margin-on-right-side branch August 23, 2023 04:58
@bigint bigint changed the title fix settings icon padding fix: settings icon margin in notification Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings icon don't have enough space aka margin on right side
2 participants