Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove network prop in zora worker #3698

Merged
merged 2 commits into from Sep 4, 2023
Merged

chore: remove network prop in zora worker #3698

merged 2 commits into from Sep 4, 2023

Conversation

bigint
Copy link
Member

@bigint bigint commented Sep 4, 2023

What does this PR do?

🤖 Generated by Copilot at d2201d5

Removed the network parameter from the Zora NFT fetching logic across the web app, the lib package, and the workers package. This simplifies the code and avoids unnecessary network switching, as the network can be derived from the chain ID.

Related issues

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Explanation of the changes

🤖 Generated by Copilot at d2201d5

  • Remove network property from nftMetadata object and useZoraNft hook call in Nft component (link, link)
  • Remove network property from useZoraNft hook interface and implementation in useZoraNft.ts (link, link, link, link)
  • Remove network property from return value of getZoraNft function in getZoraNft.ts (link, link)
  • Remove network property from query validation and fetch URL in getNft handler in getNft.ts and define network based on chain and mainnetChains (link)

Emoji

🔥🌐🎨

@vercel
Copy link

vercel bot commented Sep 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
prerender ✅ Ready (Inspect) Visit Preview Sep 4, 2023 5:53am
web ✅ Ready (Inspect) Visit Preview Sep 4, 2023 5:53am

@bigint bigint merged commit 052b13d into main Sep 4, 2023
4 of 8 checks passed
@bigint bigint deleted the rm-network-prop branch September 4, 2023 05:50
@vercel vercel bot temporarily deployed to Preview – prerender September 4, 2023 05:53 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant