Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "not logged in" page #3738

Merged
merged 5 commits into from Sep 11, 2023

Conversation

foolo
Copy link
Contributor

@foolo foolo commented Sep 7, 2023

What does this PR do?

Fixes #2670

Screencast.2023-09-07.12.46.39.mp4

🤖 Generated by Copilot at 46772cf

Replaced Custom404 with NotLoggedIn component in various components and pages that require authentication. This improves the user experience and feedback by showing a relevant message and a login button to the unauthenticated users. Created a new component NotLoggedIn in apps/web/src/pages/notloggedin.tsx to handle this logic.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Explanation of the changes

🤖 Generated by Copilot at 46772cf

Emoji

🚪🔑🛑

@foolo foolo requested a review from bigint as a code owner September 7, 2023 10:52
@foolo foolo linked an issue Sep 7, 2023 that may be closed by this pull request
1 task
@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
prerender ✅ Ready (Inspect) Visit Preview Sep 11, 2023 9:22am
web ✅ Ready (Inspect) Visit Preview Sep 11, 2023 9:22am

@bigint
Copy link
Member

bigint commented Sep 7, 2023

@foolo Try adding login button there in main context itself

@foolo
Copy link
Contributor Author

foolo commented Sep 7, 2023

@foolo Try adding login button there in main context itself

@bigint Hope I understand you correctly, I added a "Login" button under the message like this:
Screenshot_2023-09-07_15-43-03

@bigint bigint merged commit 625ce5e into main Sep 11, 2023
3 of 6 checks passed
@bigint bigint deleted the 2670-error-404-when-logging-out-from-some-pages-1 branch September 11, 2023 09:20
@vercel vercel bot temporarily deployed to Preview – prerender September 11, 2023 09:22 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error 404 when logging out from some pages
2 participants