New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add "not logged in" page #3738
Merged
bigint
merged 5 commits into
main
from
2670-error-404-when-logging-out-from-some-pages-1
Sep 11, 2023
Merged
feat: add "not logged in" page #3738
bigint
merged 5 commits into
main
from
2670-error-404-when-logging-out-from-some-pages-1
Sep 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@foolo Try adding login button there in main context itself |
bigint
reviewed
Sep 7, 2023
bigint
deleted the
2670-error-404-when-logging-out-from-some-pages-1
branch
September 11, 2023 09:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2670
Screencast.2023-09-07.12.46.39.mp4
🤖 Generated by Copilot at 46772cf
Replaced
Custom404
withNotLoggedIn
component in various components and pages that require authentication. This improves the user experience and feedback by showing a relevant message and a login button to the unauthenticated users. Created a new componentNotLoggedIn
inapps/web/src/pages/notloggedin.tsx
to handle this logic.Type of change
Explanation of the changes
🤖 Generated by Copilot at 46772cf
<Custom404 />
with<NotLoggedIn />
in the return value of several components that require authentication (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)Custom404
withNotLoggedIn
in the same components (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)NotLoggedIn
inapps/web/src/components/Messages/Message.tsx
(link)NotLoggedIn
inapps/web/src/pages/notloggedin.tsx
that shows a message to the user that they are not logged in and need to log in to continue (link)Emoji
🚪🔑🛑