Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add alert prompt before deleting the account #376

Merged
merged 2 commits into from
Aug 14, 2022
Merged

feat: add alert prompt before deleting the account #376

merged 2 commits into from
Aug 14, 2022

Conversation

andriishupta
Copy link
Contributor

@andriishupta andriishupta commented Aug 12, 2022

Fixes #63

Screenshots

image

image

@vercel
Copy link

vercel bot commented Aug 12, 2022

@andriishupta is attempting to deploy a commit to the Lenster Team on Vercel.

A member of the Team first needs to authorize it.

@bigint bigint changed the title feat: Add alert prompt before deleting the account feat: add alert prompt before deleting the account Aug 13, 2022
@vercel
Copy link

vercel bot commented Aug 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lenster ✅ Ready (Inspect) Visit Preview Aug 14, 2022 at 11:49AM (UTC)

@vercel vercel bot temporarily deployed to Preview August 13, 2022 02:30 Inactive
@andriishupta andriishupta marked this pull request as ready for review August 13, 2022 04:10
@andriishupta andriishupta enabled auto-merge (rebase) August 13, 2022 04:11
@andriishupta
Copy link
Contributor Author

@bigint put PR in "Ready for review" such seems that you rebased it and deployed it and maybe wanted merge(not sure if you can update "Draft" status)

Please, let me know if any updates to texts, logic are needed

thanks!

Copy link
Member

@bigint bigint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Rad LGTM

src/components/Settings/Delete/index.tsx Outdated Show resolved Hide resolved
src/components/Settings/Delete/index.tsx Show resolved Hide resolved
@bigint bigint merged commit b9e70cb into heyxyz:main Aug 14, 2022
@andriishupta
Copy link
Contributor Author

Thanks for review! 🙇

@andriishupta
Copy link
Contributor Author

@bigint, and sometimes I will have the urge to justify/explain "why I did that" cause programming is like 50 shades of gray - everyone has own kink 🧨 depending on previous experience

But I am learning your preferred way of things 😉

Thanks for merging!

@andriishupta andriishupta deleted the bug/63-Add_alert_prompt_before_deleting_the_account branch August 14, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add alert prompt before deleting the account
2 participants