Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crop oembed images to constant aspect ratio #3764

Merged

Conversation

foolo
Copy link
Contributor

@foolo foolo commented Sep 12, 2023

What does this PR do?

@bigint Not sure if i understood the desired behavior. But here's something to start with

Fixes #3084

Before:

Screenshot_2023-09-12_15-30-43

After:

Screenshot_2023-09-12_15-32-26

πŸ€– Generated by Copilot at d217ad8

Added classes to Image component to fix aspect ratio and stretching of oembed images in Embed.tsx.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Explanation of the changes

πŸ€– Generated by Copilot at d217ad8

  • Preserve aspect ratio and avoid stretching of embedded images in oembed component (link)

Emoji

πŸ–ΌοΈπŸ§‘β€πŸŽ¨πŸ”—

@foolo foolo requested a review from bigint as a code owner September 12, 2023 13:35
@foolo foolo linked an issue Sep 12, 2023 that may be closed by this pull request
@height
Copy link

height bot commented Sep 12, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

πŸ’‘Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@vercel
Copy link

vercel bot commented Sep 12, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
prerender βœ… Ready (Inspect) Visit Preview Sep 12, 2023 1:35pm
web βœ… Ready (Inspect) Visit Preview Sep 12, 2023 1:35pm

@bigint bigint changed the title crop oembed images to constant aspect ratio fix: crop oembed images to constant aspect ratio Sep 13, 2023
@bigint bigint merged commit 9d8f7bf into main Sep 13, 2023
10 checks passed
@bigint bigint deleted the 3084-fix-oembed-image-height-and-width-and-follow-aspect-ratio branch September 13, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix oembed image height and width and follow aspect ratio
2 participants