Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dropdown menu items layout #3775

Merged
merged 2 commits into from Sep 14, 2023

Conversation

foolo
Copy link
Contributor

@foolo foolo commented Sep 13, 2023

What does this PR do?

Wrap lines correctly when translation is longer than what fits in one line.
Note that this behavior is to be considered as an exception or a fallback for when a translation is too long. The translation should be shortened if possible.

Fixes #2566

Before

Screenshot_2023-09-13_22-21-58

After

Screenshot_2023-09-13_22-14-01

🤖 Generated by Copilot at 5e95188

Added text-left class and div elements to various components in apps/web/src/components/Shared/Navbar/NavItems to improve the alignment and layout of the navbar items. This is part of a UI improvement for the navbar.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Explanation of the changes

🤖 Generated by Copilot at 5e95188

  • Wrapped icon and text elements in separate div elements for consistent layout in navbar items ([link](https://github.com/lensterxyz/lenster/pull/3775/files?diff=unified&w=0#diff-8560795391d738fcac0b11db65278b07729ae4db70ac4a2202be56cdc66e12daL29-R32), [link](https://github.com/lensterxyz/lenster/pull/3775/files?diff=unified&w=0#diff-d60672611e7912e08143cc46dd8067db05f5347e38c5de8c91325f6f74be10d4L18-R21), [link](https://github.com/lensterxyz/lenster/pull/3775/files?diff=unified&w=0#diff-8f49aa8d53c668fcd72bc38d801a3dde568f2ecaca32d5ebe7955502a76c2849L18-R21), [link](https://github.com/lensterxyz/lenster/pull/3775/files?diff=unified&w=0#diff-f7dfd2f3606ebeac81cccf7099f0c10630aa52bcd14f9e07b303d2dde1c7de44L45-R47), [link](https://github.com/lensterxyz/lenster/pull/3775/files?diff=unified&w=0#diff-413aa9fea127c744a9a7e4da451fd8a12a5823ada5b7d4d2fcf2f1973d0182f9L26-R28), [link](https://github.com/lensterxyz/lenster/pull/3775/files?diff=unified&w=0#diff-bc44765ee34e6353be0106129507d5e4e85f5bb5ad7efb714f671e02411dd8ebL35-R38), [link](https://github.com/lensterxyz/lenster/pull/3775/files?diff=unified&w=0#diff-bc44765ee34e6353be0106129507d5e4e85f5bb5ad7efb714f671e02411dd8ebL42-R47), [link](https://github.com/lensterxyz/lenster/pull/3775/files?diff=unified&w=0#diff-b46950cf27d39629f9396e196477a89e8aaedc44d9371a10ef599e7c5cc8825fL18-R21))

Emoji

🎨🛠️🌐

@foolo foolo requested a review from bigint as a code owner September 13, 2023 20:23
@foolo foolo linked an issue Sep 13, 2023 that may be closed by this pull request
@linear
Copy link

linear bot commented Sep 13, 2023

ENG-64

@vercel
Copy link

vercel bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
prerender ✅ Ready (Inspect) Visit Preview Sep 14, 2023 5:34am
web ✅ Ready (Inspect) Visit Preview Sep 14, 2023 5:34am

@vercel vercel bot temporarily deployed to Preview – prerender September 14, 2023 05:31 Inactive
@bigint bigint merged commit 56abc16 into main Sep 14, 2023
7 of 9 checks passed
@bigint bigint deleted the 2566-eng-64-fix-profile-dropdown-for-other-languages branch September 14, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENG-64] Fix profile dropdown for other languages
2 participants