Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: profile popover don't show for wrong usernames #3778

Merged

Conversation

bhavya2611
Copy link
Contributor

@bhavya2611 bhavya2611 commented Sep 14, 2023

What does this PR do?

🤖 Generated by Copilot at d11c219

Improve user preview component in apps/web/src/components/Shared/UserPreview.tsx. Simplify loading, hide empty component, and remove redundant Tippy wrappers.

Related issues

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Explanation of the changes

🤖 Generated by Copilot at d11c219

  • Simplify loading condition for user preview component (link)
  • Hide user preview component if no profile data is available (link, link)
  • Add conditional rendering of Tippy component to avoid empty tooltip (link)

Emoji

🧹🙈🚫

@bhavya2611 bhavya2611 self-assigned this Sep 14, 2023
@linear
Copy link

linear bot commented Sep 14, 2023

ENG-149

@vercel
Copy link

vercel bot commented Sep 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
prerender ✅ Ready (Inspect) Visit Preview Sep 14, 2023 2:57pm
web ✅ Ready (Inspect) Visit Preview Sep 14, 2023 2:57pm

@bigint bigint merged commit c9b275d into main Sep 14, 2023
7 of 8 checks passed
@bigint bigint deleted the eng-149-profile-popover-loading-infinitely-if-username-is-wrong branch September 14, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants