feat: add lazy userpreview for all profiles #3884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
bigint
reviewed
Oct 5, 2023
bigint
requested changes
Oct 6, 2023
| alt={formatHandle(lazyProfile?.handle)} | ||
| /> | ||
| ); | ||
| const [fakeLoading, setFakeLoading] = useState<boolean>(loading); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Comment on lines
49
to
51
| if (!handle && !profile) { | ||
| throw new Error('UserPreview needs to receive a profile or a handle'); | ||
| } |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
bigint
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
🤖 Generated by Copilot and @Clueed at ac463fb
This pull request make UserPreview always fetch from network (f77ad07).
Instead, the passed in profile is used as fallback when there is a network error (ac463fb).
Related issues
Fixes #3723
Type of change
Explanation of the changes
🤖 Generated by Copilot at ac463fb
UserPreviewcomponent to useuseProfileLazyQueryhook andlazyProfilestate variable to fetch profile data on hover and improve performance (link)isVerifiedandhasMisusedfunctions to avoid errors whenlazyProfileorlazyProfile.idis undefined (link)UserProfileContentcomponent fromUserPreviewto simplify and reuse profile content rendering (link)lazyProfileprop withcompositeProfileprop inSuperFollow,Follow, and bio rendering to ensure latest profile data is passed and shown (link, link, link, link)lazyProfileprop withcompositeProfileprop in total following and followers count rendering to ensure count is updated with fetched profile data (link, link)onPreviewStartfunction to useloadProfilehook without awaiting or setting loading state and move loading and profile content rendering logic toPreviewcomponent (link)Preview
Screen.Recording.2023-10-05.at.12.34.08.mov
Emoji
🚀🧑💻🖼️
/claim #3723