Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wallet only collect #3975

Merged
merged 4 commits into from Nov 9, 2023
Merged

feat: wallet only collect #3975

merged 4 commits into from Nov 9, 2023

Conversation

bigint
Copy link
Member

@bigint bigint commented Nov 9, 2023

What does this PR do?

🤖 Generated by Copilot at e379f4e

This pull request simplifies and refactors the authentication and feed components in the web app. It adds a feature that allows the user to sign in with Lens without selecting a profile first, and fixes some potential errors and performance issues. It also renames some variables and adds an id field to the feed item fragment in the Feed.graphql query.

Related issues

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Explanation of the changes

🤖 Generated by Copilot at e379f4e

  • Simplify the authentication flow and remove the logic and props that handle the profile creation and the claim site redirection from the Login component and its children (link, link, link, link, link)
  • Add a feature that allows the user to sign in with Lens without selecting a profile first, and render a placeholder div in the MenuItems component if the profileId is an eth address (link, link, link, link, link)
  • Refactor the feed components to improve the naming consistency and clarity, and use the feed item id as the key prop instead of the index and the root typename (link, link, link, link)
  • Simplify the logic of the Commented component that renders a feed item of type commented, and remove the unnecessary variables and conditions that check for the first comment and its parent (link)
  • Remove the logic that logs out the user if the profile is not found from the Layout component (link)
  • Add a null check for the write function before calling it in the CollectModule component to prevent a possible error (link)
  • Remove unnecessary code and dependencies from the components, such as unused imports and variables (link, link)

Emoji

🔧🚀🐛

Copy link

height bot commented Nov 9, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
prerender ✅ Ready (Inspect) Visit Preview Nov 9, 2023 0:53am
web ✅ Ready (Inspect) Visit Preview Nov 9, 2023 0:53am

@vercel vercel bot temporarily deployed to Preview – prerender November 9, 2023 12:48 Inactive
@bigint bigint merged commit 7139183 into main Nov 9, 2023
9 checks passed
@bigint bigint deleted the wallet-auth branch November 9, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant