Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove impressions worker #3989

Merged
merged 1 commit into from Nov 13, 2023
Merged

cleanup: remove impressions worker #3989

merged 1 commit into from Nov 13, 2023

Conversation

bigint
Copy link
Member

@bigint bigint commented Nov 13, 2023

What does this PR do?

🤖 Generated by Copilot at 12a5a1f

Refactored the Leafwatch worker to handle both web app and service worker data ingestion and removed the Impressions worker. Updated the web app, service worker, data package, and documentation to reflect the changes in the worker endpoints and ports.

Related issues

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Explanation of the changes

🤖 Generated by Copilot at 12a5a1f

  • Consolidate impression tracking logic in Leafwatch worker and remove Impressions worker (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Rename ingest handler to events and register /events route in leafwatch/src/index.ts (link, link, link)
  • Rename impressions/src/handlers/ingest.ts to leafwatch/src/handlers/impressions.ts and register /impressions route in leafwatch/src/index.ts (link, link, link)
  • Update impressionsEndpoint constant in service-workers/index.ts to point to /impressions route of Leafwatch worker (link)
  • Delete Impressions worker files and remove entry from docs/ports.md (link, link, link, link, link, link, link, link, link, link, link)
  • Update web app to send response data to /events route of Leafwatch worker (link)
  • Adjust ports for Sitemap, Features, and Pro workers and update documentation and configuration files accordingly (link, link, link, link, link)

Emoji

🔄🚚📝

Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
prerender ✅ Ready (Inspect) Visit Preview Nov 13, 2023 3:40pm
web ✅ Ready (Inspect) Visit Preview Nov 13, 2023 3:40pm

Copy link

height bot commented Nov 13, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@bigint bigint merged commit db7f499 into main Nov 13, 2023
5 of 8 checks passed
@bigint bigint deleted the merge-imp-with-lw branch November 13, 2023 15:35
@vercel vercel bot temporarily deployed to Preview – prerender November 13, 2023 15:35 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant