Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add polls on fe #4070

Merged
merged 6 commits into from Nov 26, 2023
Merged

feat: add polls on fe #4070

merged 6 commits into from Nov 26, 2023

Conversation

bigint
Copy link
Member

@bigint bigint commented Nov 26, 2023

What does this PR do?

πŸ€–[deprecated] Generated by Copilot at 84ebc5f

Refactored the web app and the API to use the new Snapshot API endpoint for creating polls, and updated the terminology and schema to match the Snapshot documentation. Removed unused files and variables related to the old API. Renamed pollConfig.choices to pollConfig.options throughout the codebase for clarity and consistency.

Related issues

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Explanation of the changes

πŸ€–[deprecated] Generated by Copilot at 84ebc5f

  • Removed unused code and files related to the old Snapshot integration for creating polls (link, link, link, link, link, link)
  • Updated the API endpoint and schema for creating polls to use the new Lens protocol and return the poll ID (link, link, link)
  • Renamed the pollConfig.choices property to pollConfig.options throughout the web app to match the new API schema and avoid confusion with the Snapshot term "choice" (link, link, link, link, link, link, link, link)
  • Imported the MetadataAttributeType enum from the @lens-protocol/metadata package and used it to add the poll ID as a metadata attribute to the publication in the NewPublication component (apps/web/src/components/Composer/NewPublication.tsx) (link, link)

Emoji

πŸ—³οΈπŸ”„πŸ§Ή

Copy link

height bot commented Nov 26, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

πŸ’‘Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

vercel bot commented Nov 26, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
api βœ… Ready (Inspect) Visit Preview Nov 26, 2023 0:17am
prerender βœ… Ready (Inspect) Visit Preview Nov 26, 2023 0:17am
web βœ… Ready (Inspect) Visit Preview Nov 26, 2023 0:17am

@vercel vercel bot temporarily deployed to Preview – prerender November 26, 2023 12:01 Inactive
@vercel vercel bot temporarily deployed to Preview – api November 26, 2023 12:02 Inactive
@vercel vercel bot temporarily deployed to Preview – prerender November 26, 2023 12:09 Inactive
@vercel vercel bot temporarily deployed to Preview – api November 26, 2023 12:10 Inactive
@vercel vercel bot temporarily deployed to Preview – prerender November 26, 2023 12:13 Inactive
@bigint bigint merged commit 6fc0619 into main Nov 26, 2023
6 of 9 checks passed
@bigint bigint deleted the poll-fe branch November 26, 2023 12:13
@vercel vercel bot temporarily deployed to Preview – api November 26, 2023 12:14 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant