Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: link to profile on bottom navbar #4233

Merged
merged 3 commits into from Dec 15, 2023
Merged

feat: link to profile on bottom navbar #4233

merged 3 commits into from Dec 15, 2023

Conversation

Jaimin25
Copy link
Contributor

What does this PR do?

A link to open profile when user is logged in on mobile view

bandicam.2023-12-14.17-39-34-010.mp4

Related issues

Fixes #4157

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@vercel Vercel
Copy link

vercel bot commented Dec 14, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web ✅ Ready (Inspect) Visit Preview Dec 15, 2023 4:36am

@bigint
Copy link
Member

bigint commented Dec 14, 2023

We actually need to show avatar instead of icon 🙇🏼

@Jaimin25
Copy link
Contributor Author

We actually need to show avatar instead of icon 🙇🏼

on it

@Jaimin25
Copy link
Contributor Author

We actually need to show avatar instead of icon 🙇🏼

like this?
image

bigint
bigint requested changes Dec 14, 2023
View reviewed changes
Copy link
Member

@bigint bigint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good

apps/web/src/components/Shared/Navbar/BottomNavigation.tsx Outdated Show resolved Hide resolved
bigint
bigint requested changes Dec 14, 2023
View reviewed changes
Copy link
Member

@bigint bigint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good

apps/web/src/components/Shared/Navbar/BottomNavigation.tsx Outdated Show resolved Hide resolved
@Jaimin25 Jaimin25 requested a review from bigint December 15, 2023 04:41
@bigint bigint merged commit 905d35b into heyxyz:main Dec 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigint bigint Awaiting requested review from bigint bigint is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Hey 🌸
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add link to profile on bottom navbar
2 participants
@Jaimin25 @bigint