New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add docker support #4348
feat: add docker support #4348
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@ezhil56x can you make a short video running this on docker 🙇🏼 ? |
@bigint is attempting to deploy a commit to the Hey Team on Vercel. A member of the Team first needs to authorize it. |
@bigint, Here is the working demo. Most of the time was for building images. Skip to last few minutes to see deployment 2023-12-26.22-11-09.mp4 |
manual env copy are hard with headless machines like railway 🙈 |
Only when we pass env as file in compose, it's working. Can I add a script then? |
for compose its fine, but while deploying docker to prod? is it possible to pass env vars? |
Yeah it is possible to pass through |
@bigint Any update? 🙈 |
Can you deploy OG app to dockerhub and deploy in railway?
|
As discussed before, hot reload uses only the node runtime instead of the run time that's on the host Do you want me to deploy only the og app that is under |
Yes you can deploy, so if we using only for deployment why we need compose file? |
Compose file is easy to use than |
Who will be the users gonna use docker compose? devs / devops? |
Devops |
Do they gonna use docker compose? im not sure it will be helpful if we are using railway 🙇🏼 cuz each service will be deployed on different servers |
That can be removed if not needed. I have developed on Railway. Can you check your Dm on WA |
@bigint All changes are done 🙇🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this PR do?
Related issues
Fixes #3896
/claim #3896
Type of change
Explanation of the changes
api
,web
, andog