Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add docker support #4348

Merged
merged 12 commits into from Dec 28, 2023
Merged

feat: add docker support #4348

merged 12 commits into from Dec 28, 2023

Conversation

ezhil56x
Copy link
Contributor

@ezhil56x ezhil56x commented Dec 26, 2023

What does this PR do?

  • This PR is to implement dockerization to heyxyz/hey

Related issues

Fixes #3896
/claim #3896

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Explanation of the changes

  • Implemented dockerization to heyxyz
  • Can build docker images of api, web, and og
  • Setup workflow that gets triggered when there is a push on the repo
  • Workflow builds and pushes the images to dockerhub

Copy link

vercel bot commented Dec 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web ✅ Ready (Inspect) Visit Preview Dec 28, 2023 2:59pm

@bigint
Copy link
Member

bigint commented Dec 26, 2023

@ezhil56x can you make a short video running this on docker 🙇🏼 ?

Copy link

vercel bot commented Dec 26, 2023

@bigint is attempting to deploy a commit to the Hey Team on Vercel.

A member of the Team first needs to authorize it.

@ezhil56x
Copy link
Contributor Author

ezhil56x commented Dec 26, 2023

@bigint, Here is the working demo. Most of the time was for building images. Skip to last few minutes to see deployment

2023-12-26.22-11-09.mp4

@bigint
Copy link
Member

bigint commented Dec 26, 2023

manual env copy are hard with headless machines like railway 🙈

@ezhil56x
Copy link
Contributor Author

ezhil56x commented Dec 26, 2023

manual env copy are hard with headless machines like railway 🙈

Only when we pass env as file in compose, it's working. Can I add a script then?

@bigint
Copy link
Member

bigint commented Dec 26, 2023

for compose its fine, but while deploying docker to prod? is it possible to pass env vars?

@ezhil56x
Copy link
Contributor Author

for compose its fine, but while deploying docker to prod? is it possible to pass env vars?

Yeah it is possible to pass through docker run -e VARIABLE ...

@bigint bigint changed the title feat: dockerize hey infra ENG-4 feat: dockerize hey infra Dec 26, 2023
@bigint bigint changed the title ENG-4 feat: dockerize hey infra [ENG-4] feat: dockerize hey infra Dec 26, 2023
@heyxyz heyxyz deleted a comment from notion-workspace bot Dec 26, 2023
@bigint bigint changed the title [ENG-4] feat: dockerize hey infra feat: dockerize hey infra Dec 26, 2023
@heyxyz heyxyz deleted a comment from notion-workspace bot Dec 26, 2023
@ezhil56x
Copy link
Contributor Author

@bigint Any update? 🙈

@bigint
Copy link
Member

bigint commented Dec 28, 2023

Can you deploy OG app to dockerhub and deploy in railway?

  • We are missing devcontainers
  • We are missing deployment workflows

@ezhil56x
Copy link
Contributor Author

ezhil56x commented Dec 28, 2023

Can you deploy OG app to dockerhub and deploy in railway?

  • We are missing devcontainers
  • We are missing deployment workflows

As discussed before, hot reload uses only the node runtime instead of the run time that's on the host

Do you want me to deploy only the og app that is under apps/og for now?

@bigint
Copy link
Member

bigint commented Dec 28, 2023

Yes you can deploy, so if we using only for deployment why we need compose file?

@ezhil56x
Copy link
Contributor Author

Yes you can deploy, so if we using only for deployment why we need compose file?

Compose file is easy to use than docker run ... and passing the env in cli

@bigint
Copy link
Member

bigint commented Dec 28, 2023

Who will be the users gonna use docker compose? devs / devops?

@ezhil56x
Copy link
Contributor Author

Who will be the users gonna use docker compose? devs / devops?

Devops

@bigint
Copy link
Member

bigint commented Dec 28, 2023

Do they gonna use docker compose? im not sure it will be helpful if we are using railway 🙇🏼 cuz each service will be deployed on different servers

@ezhil56x
Copy link
Contributor Author

ezhil56x commented Dec 28, 2023

Do they gonna use docker compose? im not sure it will be helpful if we are using railway 🙇🏼 cuz each service will be deployed on different servers

That can be removed if not needed. I have developed on Railway. Can you check your Dm on WA

@ezhil56x
Copy link
Contributor Author

@bigint All changes are done 🙇🏼

.github/workflows/dockerhub.yml Outdated Show resolved Hide resolved
.github/workflows/dockerhub.yml Outdated Show resolved Hide resolved
.github/workflows/dockerhub.yml Outdated Show resolved Hide resolved
.github/workflows/dockerhub.yml Outdated Show resolved Hide resolved
@bigint bigint changed the title feat: dockerize hey infra feat: add docker support Dec 28, 2023
Copy link
Member

@bigint bigint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

LGTM

@bigint bigint merged commit 6269ba9 into heyxyz:main Dec 28, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Dockerization Proposal for heyxyz/hey
2 participants