-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate headless ui components to radix primitives #4517
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@sdthakral33 is attempting to deploy a commit to the Hey Team on Vercel. A member of the Team first needs to authorize it. |
@bigint Please review this PR, I have closed the previous PR because of its huge divergence from main branch. I have fixed all the issue reported by you in the previous PR. |
@bigint Any Updates? |
@bigint Addressed all the review comments. Please review! |
@bigint Any Updates on this? |
Screen.Recording.2024-01-15.at.10.27.38.AM.movdropdown misplaced, @sdthakral33 can you please cross check with prod? we need it to be pixel perfect 🙏🏼 |
Screen.Recording.2024-01-15.at.10.28.55.AM.movcls because of scroll gets hidden on overall layout |
@bigint Please check now!!! |
@bigint Any Updates??? |
Screen.Recording.2024-01-17.at.10.10.26.AM.movopening modals are not smooth tbh |
@bigint Please check now, added transition to Dialog Overlay also. |
Screen.Recording.2024-01-18.at.8.20.25.AM.movI'm still seeing the same, also seeing white blink, you can watch this video in slow-mo! |
I see lot of back and forth 🙇🏼, feel free to don't stress out 🤞🏼 |
@bigint - But the effect is the same that was present in headless UI code. And IMO, the behaviour also seems to same. Can you post a video to show a comparison panel between production and my branch |
Closing this for now, as radix is not meeting Hey's requirements! |
What does this PR do?
Related issues
/claim #4327
Fixes #4327
Type of change
Explanation of the changes
All the components like menus, modals and tabs using headlessui components have been migrated to radix ui primitive components