Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error message text overflow #4527

Merged
merged 1 commit into from
Jan 17, 2024
Merged

fix: error message text overflow #4527

merged 1 commit into from
Jan 17, 2024

Conversation

maxnth
Copy link
Contributor

@maxnth maxnth commented Jan 13, 2024

What does this PR do?

Fixes horizontal text overflow in the error message modal.

Before 👇
After 👇

Related issues

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Explanation of the changes

Adds the tailwindcss class break-words to the error message text content to force mid-word breaks if necessary for cases where the text would otherwise horizontally overflow the modal.

@maxnth maxnth requested a review from bigint as a code owner January 13, 2024 16:31
Copy link

vercel bot commented Jan 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web ✅ Ready (Inspect) Visit Preview Jan 13, 2024 4:34pm

Copy link

vercel bot commented Jan 13, 2024

@maxnth is attempting to deploy a commit to the Hey Team on Vercel.

A member of the Team first needs to authorize it.

@bigint
Copy link
Member

bigint commented Jan 14, 2024

@maxnth can you please attach before and after screenshots 🙇🏼

@maxnth
Copy link
Contributor Author

maxnth commented Jan 14, 2024

@maxnth can you please attach before and after screenshots 🙇🏼

@bigint already attached them in the original post, just click on the "Before 👇" / "After 👇" buttons to expand the corresponding sections

Copy link
Member

@bigint bigint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

LGTM

@bigint bigint merged commit c2bc375 into heyxyz:main Jan 17, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants