Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add message list #755

Merged
merged 21 commits into from
Oct 10, 2022
Merged

feat: add message list #755

merged 21 commits into from
Oct 10, 2022

Conversation

bhavya2611
Copy link
Contributor

@bhavya2611 bhavya2611 commented Oct 7, 2022

What does this PR do?

Adds a message list component and a message composer component. Please note, the height of the containers is something to be fixed and will be done later, minor styling issues might also be present which are not given top priority yet.

Type of change

  • Enhancement (non-breaking small changes to existing functionality)

How should this be tested?

  • See if the messages get loaded correctly for each user

Screenshots

image

image

@vercel
Copy link

vercel bot commented Oct 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lenster ✅ Ready (Inspect) Visit Preview Oct 10, 2022 at 5:59AM (UTC)

@bhavya2611 bhavya2611 self-assigned this Oct 7, 2022
@vercel vercel bot temporarily deployed to Preview October 7, 2022 10:05 Inactive
@bigint bigint changed the title Feat/message list feat: add message list Oct 7, 2022
@vercel vercel bot temporarily deployed to Preview October 7, 2022 16:25 Inactive
Copy link
Member

@bigint bigint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhavya2611 left some comments 🙇🏼

src/components/Shared/MessageComposer.tsx Outdated Show resolved Hide resolved
src/components/Shared/MessageComposer.tsx Outdated Show resolved Hide resolved
src/components/Shared/MessagesList.tsx Outdated Show resolved Hide resolved
src/components/Shared/MessagesList.tsx Outdated Show resolved Hide resolved
src/components/Shared/MessagesList.tsx Outdated Show resolved Hide resolved
src/components/Shared/MessagesList.tsx Outdated Show resolved Hide resolved
src/components/Shared/MessagesList.tsx Outdated Show resolved Hide resolved
src/components/Shared/MessagesList.tsx Outdated Show resolved Hide resolved
src/components/Shared/MessagesList.tsx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview October 8, 2022 04:40 Inactive
…ster into feat/message-list

Conflicts:
src/components/Shared/MessageComposer.tsx
src/components/Shared/MessagesList.tsx
@vercel vercel bot temporarily deployed to Preview October 8, 2022 08:20 Inactive
@vercel vercel bot temporarily deployed to Preview October 8, 2022 12:17 Inactive
@bigint
Copy link
Member

bigint commented Oct 8, 2022

image

Seems like useStreamMessages needs 2 arguments 🤔

@vercel vercel bot temporarily deployed to Preview October 8, 2022 12:23 Inactive
Copy link
Member

@bigint bigint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed some changes 🚆

LGTM :shipit:

Rad LGTM

@bigint
Copy link
Member

bigint commented Oct 8, 2022

@elisealix22 @neekolas can you review this as well 🙏🏼

@bigint bigint added this to the v1.0.3-beta milestone Oct 8, 2022
@vercel vercel bot temporarily deployed to Preview October 8, 2022 12:35 Inactive
@vercel vercel bot temporarily deployed to Preview October 9, 2022 03:08 Inactive
@vercel vercel bot temporarily deployed to Preview October 10, 2022 05:49 Inactive
…t/message-list

Conflicts:
src/components/Messages/Message.tsx
@vercel vercel bot temporarily deployed to Preview October 10, 2022 05:51 Inactive
@vercel vercel bot temporarily deployed to Preview October 10, 2022 05:54 Inactive
@vercel vercel bot temporarily deployed to Preview October 10, 2022 05:59 Inactive
@bigint bigint merged commit 1bb8f68 into main Oct 10, 2022
@bigint bigint deleted the feat/message-list branch October 10, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants