Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unkownmodules support #786

Merged
merged 40 commits into from
Nov 3, 2022
Merged

Conversation

arttu0
Copy link
Contributor

@arttu0 arttu0 commented Oct 11, 2022

What does this PR do?

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@arttu0 arttu0 requested a review from bigint as a code owner October 11, 2022 12:37
@vercel
Copy link

vercel bot commented Oct 11, 2022

Someone is attempting to deploy a commit to the Lenster Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lenster ✅ Ready (Inspect) Visit Preview Nov 3, 2022 at 2:52PM (UTC)

@vercel vercel bot temporarily deployed to Preview October 11, 2022 12:50 Inactive
@bigint bigint changed the title draft: unkownmodules support feat: unkownmodules support Oct 14, 2022
data/contracts.ts Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview October 14, 2022 11:48 Inactive
src/lib/getModule.ts Outdated Show resolved Hide resolved
@bigint
Copy link
Member

bigint commented Oct 19, 2022

@arttu0 any updates on comments?

src/lib/getModule.ts Outdated Show resolved Hide resolved
@bigint
Copy link
Member

bigint commented Oct 28, 2022

Can you resolve conflicts 🙏🏼

@vercel vercel bot temporarily deployed to Preview November 2, 2022 09:47 Inactive
@vercel vercel bot temporarily deployed to Preview November 3, 2022 14:52 Inactive
@bigint bigint merged commit 645a9ac into heyxyz:main Nov 3, 2022
@gitpoap-bot
Copy link

gitpoap-bot bot commented Nov 3, 2022

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Lenster Contributor:

GitPOAP: 2022 Lenster Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants