Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the current pagination style of demo #18

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Improve the current pagination style of demo #18

wants to merge 1 commit into from

Conversation

NiyongaboEric
Copy link
Collaborator

What does this PR do?

The PR helps different users to re-use pagination demo code into their work.

Description of Task to be completed?

  • refactor current code
  • add option style to pagination component
  • add global and customizable style
  • add paginate on top - bottom - left - right -center position of the page

How should this be manually tested?

  • git clone
  • npm i
  • npm run dev
  • git checkout paginate-user-demo

Any background context you want to provide?

The demo code was already written. I have improved in the way it will look nicer to users. If not, users will edit example.css to fit their styles. Moreover, User has the full right to position to pagination.

What are the relevant pivotal tracker stories?

Screenshots (if appropriate)

Screen Shot 2020-02-16 at 17 32 48

Questions:

Screen Shot 2020-02-16 at 17 33 44

Screen Shot 2020-02-16 at 17 34 37

Screen Shot 2020-02-16 at 17 35 12

Screen Shot 2020-02-16 at 17 36 03

Screen Shot 2020-02-16 at 17 36 38

@NiyongaboEric NiyongaboEric added bug Something isn't working ready for review and removed bug Something isn't working labels Feb 16, 2020
- refactor current code
- add option style to pagination component
- add global and customizable style
- add paginate on top - bottom - left - right -center of page
- edit Readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant