Redesign route generation to handle URL patterns #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autogenerate routes based on requesthandler method signatures Fix regex to match properly Remove debugging statements; style fixes Modify tests as required Attempt to escape URL as raw
hfaran
added a commit
that referenced
this pull request
Feb 16, 2014
Redesign route generation to handle URL patterns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Route generation will now inspect method signatures in
APIHandlers andViewHandlers, and construct routes with URL patterns based on the signatures. URL patterns match[a-zA-Z0-9_]+.Backwards Compatibility:
bodyis no longer provided byio_schemaas the sole argument to HTTP methods. Any existing code usingbodycan now useself.bodyto get the same object.resolves #6