Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore lib folder #77

Closed
gurisko opened this issue Nov 4, 2020 · 1 comment · Fixed by #78
Closed

Ignore lib folder #77

gurisko opened this issue Nov 4, 2020 · 1 comment · Fixed by #78

Comments

@gurisko
Copy link
Contributor

gurisko commented Nov 4, 2020 •
edited

There is no need to push transpiled code into the repository. It should be added into .gitignore. Also a prepare script should be added into package.json to make sure that lib is regenerated before publishing the package into npm.
@gurisko gurisko changed the title Ignore libs folder Ignore lib folder Nov 8, 2020
@hg-pyun
Copy link
Owner

hg-pyun commented Nov 9, 2020

That's a good idea. I'm busy these days so I can't really look into it. Sooner or later, I'll take some time to organize it all at once on.

@gurisko gurisko mentioned this issue Nov 12, 2020
Merged
@hg-pyun hg-pyun mentioned this issue Nov 13, 2020
Closed
8 tasks
hg-pyun pushed a commit that referenced this issue Dec 23, 2020
@gurisko
Remove lib folder (#78)
4115102 
* Remove folder with transpiled code

Fixes #77

* Fix github links in package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove lib folder
2 participants
@gurisko @hg-pyun