Fix string builder configuration #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your feedback. Some users use it except for headers. This will also require a test case and a spec definition at |
@hg-pyun The fact is that those parameters are available in types, but not used anywhere in your code. I don't see how users can use them if the code is missing :) And the readme file is also incorrect, because currently it will still print status if I'll provide test cases. |
hg-pyun
approved these changes
Dec 31, 2019
hg-pyun
added a commit
that referenced
this pull request
Dec 31, 2019
* Add build script * Update package dependencies versions * Fix string builder configuration (#44) * Add default * Add test code * fix makeDateFormat expect test case * Add banner * Fix banner size * Set global config with default config * Update version * Update version Co-authored-by: Roman Kinyakin <1@grep.su>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently logger does not use any config parameters, except headers.