feat: my attempt to support more loggers, other than just console.log #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevLehman
reviewed
Aug 11, 2020
Closed
hg-pyun
requested changes
Aug 19, 2020
added 2 commits
August 19, 2020 21:52
…. Implements feature request #53
i.e. the user has to specify the `logger` function. Defaults to: `console.log`
ClintEsteMadera
commented
Aug 20, 2020
| @@ -116,13 +116,17 @@ instance.interceptors.request.use((request) => { | |||
|
|
|||
| #### Enable config list | |||
|
|
|||
There was a problem hiding this comment.
see https://github.com/ClintEsteMadera/axios-logger/tree/add-support-for-other-loggers-than-just-console-log#enable-config-list to appreciate how this will look like. I think it's a tad cleaner this way...
|
@ClintEsteMadera I will merge tomorrow. |
|
@hg-pyun awesome! Please do let me know when the new release is published in NPM...thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm sending this contribution for your consideration. I would be really happy if this feature could be published in the library as soon as possible as I prefer not having to publish my own version in my private NPM repo...
This is the first time I contribute to an open source project so any feedback will be appreciated!
Attempts to implement the feature request #53