Explicitly set defaults in the code, as documented #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 19, 2020 21:35
…#enable-config-list, set explicitly the default values in the code, so that it's easier (mostly for contributors) to follow the code.
@hg-pyun : I've just added it, good catch! This one should be ready to merge. I will now proceed to apply the suggestions on the main one (the one about enabling other loggers) so that you are able to release v2.4.0 whenever you want and I can start using it on my project. Thanks for being so receptive to contributions! |
|
@ClintEsteMadera Thank you for contributing a good code. |
hg-pyun
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match what's documented in https://github.com/hg-pyun/axios-logger#enable-config-list, set explicitly the default values in the code, so that it's easier (mostly for contributors) to follow the code