Add support for consumer hardware #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR, very cool! I had no idea it could be done this way. Is there any downside to this method? It seems rather straightforward. I'm more inclined to make it default behaviour and remove the comment about nvlax entirely. |
|
Hey, I don't know whether nvidia will break this in the future, but I expect its purpose is to enable their Shadowplay feature on Windows is able to use NVFBC on regular cards. |
|
I suppose when that time comes, NvFBC might not work at all anymore. As far as I'm concerned we make the change from this PR default behaviour, no feature required. Can you change that? ps. I just tested this and seems to work, thanks <3 |
steven-joruk
force-pushed
the
consumer-hardware
branch
from
fb0bf0b
to
0db2690
Compare
hgaiser
approved these changes
Jan 8, 2024
|
Merged and released v0.1.5 with the change included. Thanks again 👍 |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on https://github.com/keylase/nvidia-patch/blob/master/win/nvfbcwrp/nvfbcwrp_main.cpp