Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ui fonts on mac #41

Merged
merged 1 commit into from
Jan 9, 2022
Merged

fix ui fonts on mac #41

merged 1 commit into from
Jan 9, 2022

Conversation

CharyS117
Copy link
Contributor

@CharyS117 CharyS117 commented Jan 9, 2022

YaHei is not provided on mac...

@hgjazhgj
Copy link
Owner

hgjazhgj commented Jan 9, 2022

You made a very good point!
But PingFang SC is only available on mac. It's very ugly to add platform judgment here. I would like to find a font that is relatively generic and similar to the current visuals.

@CharyS117
Copy link
Contributor Author

👍🌹

@CharyS117 CharyS117 closed this Jan 9, 2022
@hgjazhgj
Copy link
Owner

hgjazhgj commented Jan 9, 2022

Unfortunately, I can't even find one font that works on both Mac and Windows, let alone Linux, so I'll go with your solution

@hgjazhgj hgjazhgj reopened this Jan 9, 2022
@hgjazhgj hgjazhgj merged commit 9f7f623 into hgjazhgj:master Jan 9, 2022
hgjazhgj added a commit that referenced this pull request Jun 11, 2022
hgjazhgj added a commit that referenced this pull request Aug 14, 2022
@hgjazhgj hgjazhgj added the enhancement New feature or request label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants