Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PATCH requests? #20

Closed
patsplat opened this issue Jun 23, 2016 · 2 comments
Closed

PATCH requests? #20

patsplat opened this issue Jun 23, 2016 · 2 comments
Labels
enhancement

Comments

@patsplat
Copy link

Would supporting PATCH requests be a valid PR?
@hgoebl
Copy link
Owner

hgoebl commented Jun 23, 2016

There is already a branch containing PATCH. -> https://github.com/hgoebl/DavidWebb/tree/method_PATCH

The problem is, that HttpURLConnection doesn't support this method. If the underlying implementation is OkHttp, then it should work. It might also work on newer Android versions, because AFAIK they have OkHttp under the hood.

TL;DR if you have a working solution, of course this PR would be welcome!

@patsplat
Copy link
Author

Fair enough. Lived without it for long enough, closing the issue for inactivity.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@patsplat @hgoebl