Supports of BOOLEAN type, bug fix, and intellisense experience improvement. #235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
escape
functions.Details
BOOLEAN type
In Firebird3 a true BOOLEAN type has been added, however the
escape
functions of this driver didn't support it, causing an errorGDSCode.CONVERT_ERROR
with a message likeconversion error from string "1"
.Reproduzing the error
Given a table in a Firebird 3 database:
Execute the code:
Output:
Fix Potential bug
In messages.js, the
getClass
function was returning a wrong value, because it was right-shifting 30 bits instead of 28.Consider the following expressions:
Despite this function is not being used by the driver itself, it is exported, therefore it should return the correct value.
Intellisense experience
The GDSCode has been refactored changing the line comments (
// xpto
) with documentation comments (/** xpto */
). This allows intellisense capable software (like vscode) show this comments to developer.Also, the definition file now contains the whole list of codes, in order that typescript users has the intellisense benefit as well, and as now it's an enum, the developer can see the list of codes (normally with a Ctrl+space).