Automatically reconnect to database #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey - thanks for spending time working on this library, it's great!
This pull request aims to fix the following issues #195, #138.
The current solution does not work because we are resetting the socket and never reassign him.
The next problem was with bounded event handlers to socket, they were firing infinitely. The
closeevent was fired and an immediately new connection was created, again, again and again.The proposed solution fixes mentioned issues and offer a possible setting of the reconnection interval. Tested locally by simulating connection drops (force killing Firebird server).
Thanks.