Fix attaching to database if database does not exists #260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I find out that
attachOrCreate
does not work properly – thecreateDatabase
is never being called fromattachOrCreate
method.The reason is that the error from the database is detected, but there is a pitfall in
isError
method, which mark input as error only and only if it is plain object and has status property on it, but in this case, the error message with status is attached to object, which is an instance of Database.This pitfall was not detected in tests, because of not awaiting the detach method - so it never gets propagated.
Thanks.