Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use **kwargs to pass along additional arguments to ones_like #1741

Merged
merged 1 commit into from Apr 24, 2023

Conversation

keewis
Copy link
Contributor

@keewis keewis commented Apr 14, 2023

This is a fix to be included in a release before merging #1669, as the changes there would break xarray with no possible work-around. Not sure if we need tests, as those would probably be tricky to write and maintain.

@hgrecco, @jules-ch, I'd like to have a bugfix release some time soon, and include #1669 in the next release. Would that be possible? (Also, I'd be happy to help make that happen)

  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate
  • Added an entry to the CHANGES file

@hgrecco hgrecco merged commit cd68b87 into hgrecco:master Apr 24, 2023
43 checks passed
@hgrecco
Copy link
Owner

hgrecco commented Apr 24, 2023

🎉

@keewis keewis deleted the fix-full_like branch April 25, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants