Use context manager for assertWarns and fix DeprecationWarning #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failures seem to be unrelated to this PR. |
|
Why is this failing? |
|
I have fixed the issue regarding |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 30, 2019
824: Use context manager for assertWarns and fix DeprecationWarning r=hgrecco a=tirkarthi * Fix `DeprecationWarning` to use collections.abc * Starting from Python 3.8 `assertRaises` no longer accepts a None with python/cpython#8623 . So use a context manager and assert for `RuntimeWarning` This fix unblock fedora to package the library for Python 3.8 : https://bugzilla.redhat.com/show_bug.cgi?id=1706212 Thanks Co-authored-by: xtreak <tir.karthi@gmail.com>
Build succeeded |
|
Thanks @hgrecco :) |
|
Sorry for the delay, testing in travis was problematic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeprecationWarningto use collections.abcassertRaisesno longer accepts a None with bpo-34318: Convert deprecation warnings to errors in assertRaises() etc. python/cpython#8623 . So use a context manager and assert forRuntimeWarningThis fix unblock fedora to package the library for Python 3.8 : https://bugzilla.redhat.com/show_bug.cgi?id=1706212
Thanks