Add np.pad and np.resize implementations #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jthielen
force-pushed
the
numpy-pad-resize
branch
from
c5ada96
to
649672b
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 27, 2019
956: Add np.pad and np.resize implementations r=hgrecco a=jthielen As requested in pydata/xarray#3643 (comment), this PR adds implementations for `np.pad` and `np.resize`, with accompanying tests. - ~~Closes (insert issue number)~~ (#905 follow-up) - [x] Executed ``black -t py36 . && isort -rc . && flake8`` with no errors - [x] The change is fully covered by automated unit tests - [x] Documented in docs/ as appropriate - ~~Added an entry to the CHANGES file~~ (#905 follow-up) Co-authored-by: Jon Thielen <github@jont.cc>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in pydata/xarray#3643 (comment), this PR adds implementations for
np.padandnp.resize, with accompanying tests.Closes (insert issue number)(NEP-18 Compatibility #905 follow-up)black -t py36 . && isort -rc . && flake8with no errorsAdded an entry to the CHANGES file(NEP-18 Compatibility #905 follow-up)