Update FtpComponent.php #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get and put have $mode in wrong place.
|
Hi, Thanks for your help. 2 errors in your pull request :
Best regards |
|
Sorry I was a bit busy. I see that you've already fixed all. You may also check whether you have upgraded Packagist? It seems to be behind at commit c05fcb0. |
|
Hi. Packagings bas bien updates. Y ou coule usé version V2.1.2. |
|
Great! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, it seems that get and put have $mode in wrong place.
I've also fixed the event onFileDownlaoded in get method. It seems that for some reason the code contained an undefined variable. I think that $local_file is the right one.