Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location Search: Add Paging Feature to Table View #743

Open
joshi1983 opened this issue Dec 31, 2018 · 0 comments
Open

Location Search: Add Paging Feature to Table View #743

joshi1983 opened this issue Dec 31, 2018 · 0 comments

Comments

@joshi1983
Copy link
Collaborator

When more than 60 locations match the location search query in the location search's "Table" view, the locations are filtered down to roughly 60 anyway and a message is shown indicating that.

This extra filter is difficult to explain and understand for people. The intent was to reduce clustering on the Map view and keep the Table view listing the exact same information as the Map. Since completion of #721, the Table isn't matching anymore so a paging feature is more intuitive.

This new paging feature will involve:

  • Add page_size and page_offset parameters to the URL along with appropriate defaults when they're not set. A good default page_size could be 40. A good default page_offset would be 0 or 1( such that no location is skipped).
  • Modify LocationSearchController.php to increase the maximum locations from 60 or whatever it is now to 5000 or more.
  • Test speed of the location search feature after the change to see if it works at an acceptable speed. Rating calculations tend to be fairly slow and running 5000 of them may take a few seconds. Ideally, we want a fraction of a second.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant