Merge pull request #553 from hhatto/issue-551

fix: ignoring w292 with in-place option

autopep8.py

@@ -3534,7 +3534,13 @@ def fix_file(filename, options=None, output=None, apply_config=False):
     elif options.in_place:
         original = "".join(original_source).splitlines()
         fixed = fixed_source.splitlines()
-        if original != fixed:
+        original_source_last_line = (
+            original_source[-1].split("\n")[-1] if original_source else ""
+        )
+        fixed_source_last_line = fixed_source.split("\n")[-1]
+        if original != fixed or (
+            original_source_last_line != fixed_source_last_line
+        ):
             with open_with_encoding(filename, 'w', encoding=encoding) as fp:
                 fp.write(fixed_source)
             return fixed_source

test/test_autopep8.py

@@ -5360,6 +5360,28 @@ def test_in_place_no_modifications_no_writes(self):
             self.assertEqual(err, b'')
             self.assertEqual(p.returncode, autopep8.EXIT_CODE_OK)
 
+    def test_in_place_no_modifications_no_writes_with_empty_file(self):
+        with temporary_file_context('') as filename:
+            # ensure that noops do not do writes by making writing an error
+            os.chmod(filename, 0o444)
+            p = Popen(
+                list(AUTOPEP8_CMD_TUPLE) + [filename, '--in-place'],
+                stderr=PIPE,
+            )
+            _, err = p.communicate()
+            self.assertEqual(err, b'')
+            self.assertEqual(p.returncode, autopep8.EXIT_CODE_OK)
+
+    def test_in_place_with_w292(self):
+        line = "import os"
+        fixed = "import os\n"
+
+        with temporary_file_context(line) as filename:
+            p = Popen(list(AUTOPEP8_CMD_TUPLE) + [filename, '--in-place'])
+            p.wait()
+            with open(filename) as f:
+                self.assertEqual(fixed, f.read())
+
     def test_in_place_with_exit_code_option(self):
         line = "'abc'  \n"
         fixed = "'abc'\n"