Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with UMAP repository #2

Closed
lmcinnes opened this issue Jun 2, 2020 · 2 comments
Closed

Integration with UMAP repository #2

lmcinnes opened this issue Jun 2, 2020 · 2 comments

Comments

@lmcinnes
Copy link

lmcinnes commented Jun 2, 2020

Thanks for all your work -- this looks like a great addition/advancement over the standard UMAP approach. I was wondering if you would consider integrating densmap into the Python UMAP repository? I am currently adding new features in the 0.5dev branch, and I feel like DensMAP support would be a very valuable option to have for many users. If you do not have the time I certainly understand, and I can endeavour to add the feature myself, but I would certainly appreciate PRs from the original authors if possible.

If you do wish to make PRs please make sure to update READMEs and documentation to include citations/references to your paper to ensure proper credit.

@lmcinnes lmcinnes changed the title Integration with UMAP repsitory Integration with UMAP repository Jun 2, 2020
@hhcho
Copy link
Owner

hhcho commented Jun 3, 2020

Thank you for reaching out! We are big fans of the UMAP package. We are definitely interested in integrating densMAP support into Python UMAP and will put together the PR soon.

@lmcinnes
Copy link
Author

lmcinnes commented Jun 3, 2020

If you do, please make the PR against the 0.5dev branch at this time. Thanks so much for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants