Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation command #88

Open
givanse opened this issue Jul 9, 2015 · 16 comments
Open

Installation command #88

givanse opened this issue Jul 9, 2015 · 16 comments

Comments

@givanse
Copy link

givanse commented Jul 9, 2015

This wouldn't work:

ember install spree-ember-storefront

I had to use a version number:

ember install spree-ember-storefront@0.0.1-beta.1

Maybe document it? I'm not sure at what level this should be handled.

@hhff
Copy link
Owner

hhff commented Jul 10, 2015

Works for me with ember cli 0.2.7 - what CLI version are you on?

@givanse
Copy link
Author

givanse commented Jul 10, 2015

I don't know why I didn't mention it...

"ember-cli": "1.13.1"

@hhff
Copy link
Owner

hhff commented Jul 10, 2015

kk - haven't had a chance to use 1.13.1 yet. I'll look into it eventually! currently working on Instance Initializers for the project

@raybesiga
Copy link

I could not get it running at all

ember install spree-ember-storefront
version: 0.1.11
The `install` command does not take any arguments. You must use `install:npm` or `install:bower` to install a specific package.

so I defaulted to using:

npm install spree-ember-storefront

The behavior is different that described in the guide. And my ember app is not working as prescribed. Any leads?

@hhff
Copy link
Owner

hhff commented Sep 22, 2015

you may need to do ember install:addon spree-ember-storefront depending on your version of ember CLI

doing
npm install spree-ember-storefront
then
ember generate spree-ember-storefront

is equivalent, however

@raybesiga
Copy link

Hey Hugh,

So the issue was with my version of ember-cli. I cleared the cache, re-installed everything and the command worked fine. Now watching your talk at Ember London. Quite refreshing, though when I click on the products button at the bottom of the landing page, products page does not load though it seems to work fine on the command line..

Some sort of content security policy violation:

Content Security Policy violation: {"csp-report":{"document-uri":"http://localhost:4200/products","referrer":"","violated-directive":"style-src 'self'","effective-directive":"style-src","original-policy":"default-src 'none'; script-src 'self' 'unsafe-eval' localhost:49152 0.0.0.0:49152; font-src 'self'; connect-src 'self' ws://localhost:49152 ws://0.0.0.0:49152 http://0.0.0.0:4200/csp-report; img-src 'self'; style-src 'self'; media-src 'self'; report-uri http://0.0.0.0:4200/csp-report;","blocked-uri":"","source-file":"chrome-extension://gppongmhjkpfnbhagpmjfkannfbllamg","line-number":34,"column-number":15,"status-code":200}}
Content Security Policy violation: {"csp-report":{"document-uri":"http://localhost:4200/products","referrer":"","violated-directive":"style-src 'self'","effective-directive":"style-src","original-policy":"default-src 'none'; script-src 'self' 'unsafe-eval' localhost:49152 0.0.0.0:49152; font-src 'self'; connect-src 'self' ws://localhost:49152 ws://0.0.0.0:49152 http://0.0.0.0:4200/csp-report; img-src 'self'; style-src 'self'; media-src 'self'; report-uri http://0.0.0.0:4200/csp-report;","blocked-uri":"","source-file":"chrome-extension://noojglkidnpfjbincgijbaiedldjfbhh","line-number":50,"column-number":10,"status-code":200}}

Have you encountered that?

@hhff
Copy link
Owner

hhff commented Sep 22, 2015

you need to downgrade to these versions of Ember & Ember Data:

"ember": "1.12.0",
"ember-data": "1.0.0-beta.18"

We don't currently support the latest versions - we're slowly working on it but we really need a champion for it!

@hhff
Copy link
Owner

hhff commented Sep 22, 2015

You just update these in your bower.json and run a bower install 👍

@raybesiga
Copy link

My bower.json currently looks like this:

{
  "name": "madagascar",
  "dependencies": {
    "ember": "1.13.7",
    "ember-cli-shims": "ember-cli/ember-cli-shims#0.0.3",
    "ember-cli-test-loader": "ember-cli-test-loader#0.1.3",
    "ember-data": "1.13.8",
    "ember-load-initializers": "ember-cli/ember-load-initializers#0.1.5",
    "ember-qunit": "0.4.9",
    "ember-qunit-notifications": "0.0.7",
    "ember-resolver": "~0.1.18",
    "jquery": "^1.11.3",
    "loader.js": "ember-cli/loader.js#3.2.1",
    "qunit": "~1.18.0"
  }
}

Won't the changes affect the shims and test loader? Sorry, I'm a newbie to Ember so my question may be a little silly..

@hhff
Copy link
Owner

hhff commented Sep 22, 2015

give it a go and find out - this is the bower.json we developed Spree Ember against: https://github.com/ember-cli/ember-cli/blob/f924fb5d117473d881b0be6759807c1416be2be0/blueprints/app/files/bower.json

@raybesiga
Copy link

You are a god! @hhff it is working perfectly. Now contemplating whether to go learn the internal workings of Ember, or figure it out as i go. And and advise regarding swapping out Foundation for my own custom design stylesheets and javascript? Or should I stick with it and until I really get how everything works?

@baraka2000
Copy link

Ray, Don't mix any old random js with ember. Not recommended practice. Use
Ember.

Hugh, what exactly needs to happen to get this updated? Trying to figure
out if I could help?

Best,
Kevin

On Tue, Sep 22, 2015 at 10:34 AM, Ray Besiga notifications@github.com
wrote:

You are a god! @hhff https://github.com/hhff it is working perfectly.
Now contemplating whether to go learn the internal workings of Ember, or
figure it out as i go. And and advise regarding swapping out Foundation for
my own custom design stylesheets and javascript? Or should I stick with it
and until I really get how everything works?


Reply to this email directly or view it on GitHub
#88 (comment).

@raybesiga
Copy link

Thanks for the advice @baraka2000 and cheers to @hhff for getting me on this Ember train. Best regards from Kampala!

@hhff
Copy link
Owner

hhff commented Sep 22, 2015

@raybesiga - you can absolutely swap out Foundation if you want! We used Foundation because it was the most "plug and play" of the CSS Frameworks. It's meant to be swappable.

What i will say - is that Spree Ember is probably the biggest OSS Ember Addon project out there. Ember has got a really steep learning curve - so working with Spree Ember will be pretty tricky.

@baraka2000 - we basically need to get this lib working with the latest versions of Ember, Ember Data and Ember CLI. There's a failing PR up for it at the moment - but most of it is done there!

@baraka2000
Copy link

6 months later, I finally had time to have a play with this again and thanks to your help here @hhff, I got this working perfectly. Amazing! So perhaps once I dig my heels in I might level up enough to actually help on this project. I certainly would like to see this grow, thanks Hugh!

For folks following the guides with newer ember-cli versions, the trick is specifying the correct older version of ember and ember-data as outlined by hhff above (in the bower.json file). Everything else worked for me.

@hhff
Copy link
Owner

hhff commented Jan 6, 2016

Nice Kevin!
On Wed, 6 Jan 2016 at 12:23 AM, Kevin Kornemann notifications@github.com
wrote:

6 months later, I finally had time to have a play with this again and
thanks to your help here @hhff https://github.com/hhff, I got this
working perfectly. Amazing! So perhaps once I dig my heels in I might level
up enough to actually help on this project. I certainly would like to see
this grow, thanks Hugh!

For folks following the guides with newer ember-cli versions, the trick is
specifying the correct older version of ember and ember-data as outlined by
hhff above (in the bower.json file). Everything else worked for me.


Reply to this email directly or view it on GitHub
#88 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants