Skip to content

Commit

Permalink
feat(DEV-24): add section for not included
Browse files Browse the repository at this point in the history
also add how-to import svg
  • Loading branch information
hhimanshu committed Jul 6, 2021
1 parent bdbc67b commit ecd2ec0
Show file tree
Hide file tree
Showing 5 changed files with 29 additions and 2 deletions.
7 changes: 7 additions & 0 deletions README.md
Expand Up @@ -25,5 +25,12 @@ All these tools are easy to configure. Please find their documentation below

[Renovate Github App Installation](https://docs.renovatebot.com/install-github-app/)

## How tos
### How to import and use `SVG`?
```tsx
import Check from '../../../assets/check.svg'; // import
<Check /> // use
```

## Questions or Ideas?
Please [start a new discussion](https://github.com/hhimanshu/create-react-ts-starter/discussions)
2 changes: 1 addition & 1 deletion src/components/Home/Discussion/index.tsx
Expand Up @@ -9,7 +9,7 @@ export const Discussion = () => {
);

return (
<Section title={'Have ideas?'} bgColor={'#F9F8F8'}>
<Section title={'Have ideas?'}>
<Button title={'Start a discussion'} onClick={openDiscussion} />
</Section>
);
Expand Down
2 changes: 1 addition & 1 deletion src/components/Home/GetStarted/index.tsx
Expand Up @@ -7,7 +7,7 @@ export const GetStarted = () => {
window.open('https://github.com/hhimanshu/create-react-ts-starter#readme');

return (
<Section title={'Ready to get started?'}>
<Section title={'Ready to get started?'} bgColor={'#F9F8F8'}>
<Button title={'Follow README.md'} onClick={openReadMe} />
</Section>
);
Expand Down
18 changes: 18 additions & 0 deletions src/components/Home/NotIncluded/index.tsx
@@ -0,0 +1,18 @@
import React from 'react';
import { Section } from '../Section';

export const NotIncluded = () => {
return (
<Section title={'Why no redux or CSS Framework included?'}>
<p>
When it comes to client state management or using a styling solution,
there are a lot of options available. Additionally, each team or
individual have their favorites tools or needs for the problem at hand.
</p>
<p>
This project does not assume or provides any opinion on those choices,
so you are free to bring your own solution!
</p>
</Section>
);
};
2 changes: 2 additions & 0 deletions src/components/Home/index.tsx
Expand Up @@ -5,13 +5,15 @@ import { Why } from './Why';
import { Features } from './Features';
import { GetStarted } from './GetStarted';
import { Discussion } from './Discussion';
import { NotIncluded } from './NotIncluded';

export const Home = () => {
return (
<Fragment>
<Header />
<Why />
<Features />
<NotIncluded />
<GetStarted />
<Discussion />
</Fragment>
Expand Down

0 comments on commit ecd2ec0

Please sign in to comment.