This repository has been archived by the owner on May 20, 2024. It is now read-only.
Define missing return types #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-merge was automatically disabled
February 9, 2022 16:55
Head branch was pushed to by a user without write access
vfazio
force-pushed
the
vfazio-update-return-types
branch
3 times, most recently
from
4f842d4
to
694a60a
Compare
vfazio
force-pushed
the
vfazio-update-return-types
branch
from
694a60a
to
b532ff0
Compare
|
I think i've fixed the |
|
Thanks :) |
hhk7734
approved these changes
Feb 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent inclusion of py.typed, type checking highlights a number of functions missing explicit return types.
This PR looks to address the bulk of those missing return types.
This PR does not aim to resolve any return type disparities between the various classes or other mypy type checking errors within this project.